Edinburgh’s port district has shaken off its seedy rep and is having a cultural renaissance, writes Robin McKelvie